feat: add unified strategy project workflow
This commit is contained in:
1 parent
67d12929fc
commit
a26fd32eba
28 files changed
+3382
-191
No files matched your search
@@ -15,7 +15,8 @@ from fastapi import APIRouter, Depends, HTTPException, Query, Request
|
||||
from pydantic import BaseModel, Field
|
||||
|
||||
from app.gateway.auth.password import verify_password_async
|
||||
from app.gateway.deps import get_agent_store, get_config, get_tag_store
|
||||
from app.gateway.deps import get_agent_store, get_config, get_skill_store, get_tag_store
|
||||
from app.gateway.routers._strategy_selection_seed import required_agent_ids as required_strategy_agent_ids
|
||||
from deerflow.agents.lead_agent.prompt import refresh_skills_system_prompt_cache_async
|
||||
from deerflow.config.agents_api_config import get_agents_api_config
|
||||
from deerflow.config.agents_config import CommonQuestion, list_custom_agents, load_agent_config, load_agent_soul, validate_agent_id
|
||||
@@ -23,13 +24,17 @@ from deerflow.config.app_config import AppConfig
|
||||
from deerflow.config.paths import get_paths
|
||||
from deerflow.config.system_settings import load_system_settings, normalize_square_id, resolve_default_square_id
|
||||
from deerflow.persistence.agents import AgentStore
|
||||
from deerflow.persistence.skills import SkillStore
|
||||
from deerflow.persistence.tags import TagStore
|
||||
from deerflow.runtime.user_context import get_effective_user_id
|
||||
from deerflow.skills.cascade import sync_agent_skills_to_available
|
||||
from deerflow.skills.storage import get_or_new_skill_storage
|
||||
from deerflow.skills.types import SkillCategory
|
||||
from deerflow.skills.usage import all_entries as get_skill_usage_entries
|
||||
|
||||
logger = logging.getLogger(__name__)
|
||||
router = APIRouter(prefix="/api", tags=["agents"])
|
||||
_STRATEGY_SELECTION_AGENT_IDS = frozenset(required_strategy_agent_ids())
|
||||
|
||||
|
||||
class AgentResponse(BaseModel):
|
||||
@@ -276,6 +281,109 @@ def _validate_storage_id(agent_id: str) -> str:
|
||||
raise HTTPException(status_code=422, detail=str(exc)) from exc
|
||||
|
||||
|
||||
async def _validate_strategy_agent_skills(
|
||||
requested_skills: list[str] | None,
|
||||
*,
|
||||
app_config: AppConfig,
|
||||
skill_store: SkillStore,
|
||||
) -> list[str] | None:
|
||||
"""Validate a global strategy role's skill allowlist.
|
||||
|
||||
Strategy-selection agents are built-in roles shared by every project and
|
||||
every user. Their allowlists may therefore reference only canonical skill
|
||||
names that exist on disk, are enabled/active, and are globally visible:
|
||||
deployment-owned public skills, explicit built-in rows, or custom skills
|
||||
currently published by their owner. In particular, an administrator must
|
||||
not be able to attach a different user's unpublished skill merely because
|
||||
``?admin=true`` exposes it in the management catalog.
|
||||
"""
|
||||
|
||||
if requested_skills is None:
|
||||
return None
|
||||
|
||||
normalized: list[str] = []
|
||||
for raw_name in requested_skills:
|
||||
name = raw_name.strip()
|
||||
if not name:
|
||||
raise HTTPException(
|
||||
status_code=422,
|
||||
detail="Strategy agent skill names cannot be blank",
|
||||
)
|
||||
if name not in normalized:
|
||||
normalized.append(name)
|
||||
|
||||
try:
|
||||
skills = get_or_new_skill_storage(app_config=app_config).load_skills(
|
||||
enabled_only=False
|
||||
)
|
||||
ownership = {
|
||||
str(record.get("name") or ""): record
|
||||
for record in await skill_store.list_all()
|
||||
if record.get("name")
|
||||
}
|
||||
usage_entries = get_skill_usage_entries()
|
||||
except HTTPException:
|
||||
raise
|
||||
except Exception as exc: # noqa: BLE001 - stable API response
|
||||
logger.exception("Failed to validate strategy-agent skill allowlist")
|
||||
raise HTTPException(status_code=503, detail="Skill catalog is unavailable") from exc
|
||||
|
||||
by_name = {skill.name: skill for skill in skills}
|
||||
unknown = [name for name in normalized if name not in by_name]
|
||||
if unknown:
|
||||
raise HTTPException(
|
||||
status_code=422,
|
||||
detail=f"Unknown strategy agent skills: {', '.join(unknown)}",
|
||||
)
|
||||
|
||||
unavailable = [
|
||||
name
|
||||
for name in normalized
|
||||
if not by_name[name].enabled
|
||||
or str((usage_entries.get(name) or {}).get("state") or "active") != "active"
|
||||
]
|
||||
if unavailable:
|
||||
raise HTTPException(
|
||||
status_code=422,
|
||||
detail=f"Disabled or archived strategy agent skills: {', '.join(unavailable)}",
|
||||
)
|
||||
|
||||
not_global: list[str] = []
|
||||
for name in normalized:
|
||||
skill = by_name[name]
|
||||
if skill.category != SkillCategory.CUSTOM:
|
||||
continue
|
||||
record = ownership.get(name)
|
||||
if record is not None and (
|
||||
record.get("owner_user_id") is None or bool(record.get("published"))
|
||||
):
|
||||
continue
|
||||
not_global.append(name)
|
||||
if not_global:
|
||||
raise HTTPException(
|
||||
status_code=422,
|
||||
detail=(
|
||||
"Strategy agent skills must be globally available; "
|
||||
f"unpublished or unregistered custom skills: {', '.join(not_global)}"
|
||||
),
|
||||
)
|
||||
|
||||
return normalized
|
||||
|
||||
|
||||
def _ensure_strategy_agent_deletable(agent_id: str) -> None:
|
||||
"""Keep fixed strategy role ids alive; their SOUL/skills remain editable."""
|
||||
|
||||
if agent_id in _STRATEGY_SELECTION_AGENT_IDS:
|
||||
raise HTTPException(
|
||||
status_code=409,
|
||||
detail=(
|
||||
f"Strategy role agent '{agent_id}' cannot be deleted; "
|
||||
"edit its SOUL and skills instead"
|
||||
),
|
||||
)
|
||||
|
||||
|
||||
def _write_agent_config(
|
||||
agent_id: str,
|
||||
*,
|
||||
@@ -953,7 +1061,14 @@ async def update_agent(agent_id: str, request: AgentUpdateRequest, http_request:
|
||||
next_description = update_data.get("description", current.get("description") or "")
|
||||
|
||||
existing_extras = _load_config_extras(agent_id)
|
||||
next_skills = request.skills if "skills" in fields_set else existing_extras["skills"]
|
||||
if "skills" in fields_set and agent_id in _STRATEGY_SELECTION_AGENT_IDS:
|
||||
next_skills = await _validate_strategy_agent_skills(
|
||||
request.skills,
|
||||
app_config=get_config(http_request),
|
||||
skill_store=get_skill_store(http_request),
|
||||
)
|
||||
else:
|
||||
next_skills = request.skills if "skills" in fields_set else existing_extras["skills"]
|
||||
next_model = request.model if "model" in fields_set else existing_extras["model"]
|
||||
next_tool_groups = request.tool_groups if "tool_groups" in fields_set else existing_extras["tool_groups"]
|
||||
next_common_questions = request.common_questions if "common_questions" in fields_set else existing_extras["common_questions"]
|
||||
@@ -1079,6 +1194,7 @@ async def delete_agent(agent_id: str, request: Request) -> None:
|
||||
_, edit_mode = await _get_editable_or_raise(
|
||||
store, agent_id, user_id, is_admin=is_admin
|
||||
)
|
||||
_ensure_strategy_agent_deletable(agent_id)
|
||||
|
||||
if edit_mode == "admin":
|
||||
deleted = await store.delete_any(agent_id)
|
||||
|
||||
Reference in new issue
Block a user