fix(maf): harden stage-4 quality gate (P0/P1)
P0-1 migration: detect the same-named stage-3 execution_stage CHECK by sqltext (must contain rework + manager_review), SQLite rebuild / PG-MySQL drop+add, PG boolean default TRUE, validate_schema checks constraint content + seat_tasks status CHECK/unique/FKs; tests start from a real stage-3 schema. P0-2: a missing/invalid manager review (timeout/exception/empty/invalid JSON/missing per-seat decision) is never an acceptance - system rework under the cap, contract fallback (reassign/controlled_gap/ask_user) afterwards, source=system events. P0-3: unaccepted deliveries are isolated from the fact ledger, cross-review and final report (deferred merge, delivery_json envelope, accepted_task_results in checkpoint, accepted-only synthesis, no turn_results fallback). P0-4: seat-task init is atomic get-or-create over the full expected set; recovery fills missing tasks without overwriting frozen contracts; quality gate blocks missing required tasks. P1: zero config values honoured; duplicate detection persists SHA-256 conclusion digests in history (survives restarts); findings never satisfy evidence, evidence_refs must resolve to trusted ledger refs (unverified_evidence_ref); conversation SSE projection tests added and manager/finalizer messages are no longer mislabelled as seat.delivery.submitted.
This commit is contained in:
1 parent
a786cdcad0
commit
1aeee86984
24 files changed
+4706
-47
No files matched your search
@@ -430,6 +430,7 @@ class MafConversationService:
|
||||
_ALLOWED_TYPES = frozenset({
|
||||
"agent.message.start", "agent.message.delta", "agent.message.complete",
|
||||
"seat.delivery.submitted", "manager.dispatch", "manager.review.decision",
|
||||
"seat.rework.assigned", "seat.reassigned", "stage.quality_gate",
|
||||
"tool.requested", "tool.started", "tool.progress", "tool.completed", "tool.failed",
|
||||
"skill.selected", "skill.started", "skill.completed", "skill.failed",
|
||||
"artifact.created", "approval.required", "approval.decided", "clarification.required",
|
||||
@@ -437,6 +438,11 @@ class MafConversationService:
|
||||
"run.cancelled", "run.completed",
|
||||
})
|
||||
|
||||
# Execution stages whose ``agent.message.completed`` is a genuine seat
|
||||
# delivery. Manager / dispatch / review / cross-review / finalizer /
|
||||
# format-repair messages must NEVER be projected as seat.delivery.submitted.
|
||||
_SEAT_DELIVERY_STAGES = frozenset({"expert", "rework", "legacy", "group_chat"})
|
||||
|
||||
_SAFE_KEYS: dict[str, dict[str, bool]] = {
|
||||
"agent.message.start": {"thread_id": False},
|
||||
"agent.message.delta": {"text": True},
|
||||
@@ -463,10 +469,27 @@ class MafConversationService:
|
||||
"reason": True, "source": True, "clarification_prompt": True,
|
||||
},
|
||||
"clarification.required": {"prompt": True, "reason": True},
|
||||
"manager.review.decision": {"decision": True, "reason": True, "quality": True},
|
||||
"manager.review.decision": {
|
||||
"decision": True, "reason": True, "quality": True,
|
||||
"task_key": True, "attempt": True, "source": True,
|
||||
},
|
||||
"fact.confirmed": {"fact_id": True, "summary": True},
|
||||
"review.completed": {"summary": True, "decision": True},
|
||||
"seat.delivery.submitted": {"content": True, "schema_status": True},
|
||||
"seat.delivery.submitted": {
|
||||
"content": True, "schema_status": True,
|
||||
"task_key": True, "attempt": True,
|
||||
"deterministic_passed": True, "failure_codes": True,
|
||||
},
|
||||
"seat.rework.assigned": {
|
||||
"task_key": True, "rework_count": True, "revision_requirements": True,
|
||||
},
|
||||
"seat.reassigned": {
|
||||
"task_key": True, "from_agent_id": True, "reassign_count": True,
|
||||
},
|
||||
"stage.quality_gate": {
|
||||
"decision": True, "total": True, "accepted": True,
|
||||
"controlled_gap": True, "blocked_required": True,
|
||||
},
|
||||
}
|
||||
|
||||
def _build_projection_items(
|
||||
@@ -501,19 +524,26 @@ class MafConversationService:
|
||||
"source_event_id": source_evt_id,
|
||||
}]
|
||||
|
||||
# Only a genuine seat delivery turn may be projected as
|
||||
# seat.delivery.submitted. Manager / dispatch / manager_review /
|
||||
# cross-review / finalizer / format-repair messages are ordinary
|
||||
# agent messages and must never be mislabelled as seat deliveries
|
||||
# (Stage-4 runs emit their own explicit seat.delivery.submitted event).
|
||||
if source_type == "agent.message.completed":
|
||||
delivery_data: dict[str, Any] = {
|
||||
key: payload[key]
|
||||
for key in ("content", "schema_status")
|
||||
if key in payload
|
||||
}
|
||||
if event.get("agent_id"):
|
||||
delivery_data["agent_id"] = event["agent_id"]
|
||||
items.append({
|
||||
"event_type": "seat.delivery.submitted",
|
||||
"event_data": delivery_data,
|
||||
"source_event_id": f"{source_evt_id}:delivery" if source_evt_id else None,
|
||||
})
|
||||
stage = str(payload.get("execution_stage") or "")
|
||||
if stage in self._SEAT_DELIVERY_STAGES:
|
||||
delivery_data: dict[str, Any] = {
|
||||
key: payload[key]
|
||||
for key in ("content", "schema_status")
|
||||
if key in payload
|
||||
}
|
||||
if event.get("agent_id"):
|
||||
delivery_data["agent_id"] = event["agent_id"]
|
||||
items.append({
|
||||
"event_type": "seat.delivery.submitted",
|
||||
"event_data": delivery_data,
|
||||
"source_event_id": f"{source_evt_id}:delivery" if source_evt_id else None,
|
||||
})
|
||||
|
||||
return items
|
||||
|
||||
|
||||
Reference in new issue
Block a user